Skip to content

Fix registration of operation hooks in User model [2.x]#3015

Merged
bajtos merged 1 commit into
2.xfrom
fix/repeated-user-hooks-2x
Dec 9, 2016
Merged

Fix registration of operation hooks in User model [2.x]#3015
bajtos merged 1 commit into
2.xfrom
fix/repeated-user-hooks-2x

Conversation

@bajtos

@bajtos bajtos commented Dec 9, 2016

Copy link
Copy Markdown
Member

back-port of #3014

Operation hooks are inherited by subclassed models, therefore they must
be registered outside of `Model.setup()` function.

This commit fixes this problem in the built-in User model.

There are not tests verifying this change, as writing a test would be
too cumbersome and not worth the cost IMO.
@bajtos bajtos added the #review label Dec 9, 2016
@bajtos
bajtos merged commit 66e4e5b into 2.x Dec 9, 2016
@bajtos
bajtos deleted the fix/repeated-user-hooks-2x branch December 9, 2016 13:52
@bajtos bajtos removed the #review label Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant